Mark parameter to MiniSearch.removeAll as optional

[nilclass]

According to the documentation, documents is optional. However, with current typing it was not possible to call it without an argument.

I swapped the condition branches, because checking arguments.length == 0 did not rule out documents being null/undefined, so documents needs to be checked explicitly, and if (documents) seems clearer to me here than if (!documents).

[lucaong]

Hi @nilclass , great catch, thanks!

The condition has one problem now though: since an empty array is falsey in JavaScript, removeAll([]) would now remove all documents, instead of none (edit: empty array is not falsey, but the following point still stands). That is why before the check was considering the number of arguments passed: if you pass anything, that is taken to be the list of documents to remove. If one calls removeAll(x) and x happens to be falsey, there is a high chance it's unintentional, and it's better to raise an error. In order to remove all documents, one has to call removeAll() with no arguments, so it cannot happen by mistake.

One option would be to say if (documents == null), but I think that removeAll(null) should rather raise an error, as it's not a valid usage of this method. I am leaning for keeping the check on argument length. Otherwise, if (documents === undefined) would also be an option (calling removeAll(undefined) has a low chance of being unintentional).

[lucaong]

Thanks, will merge now 👍