Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Support Sketch 45 plugin update system #7

Closed
bomberstudios opened this issue Jun 1, 2017 · 5 comments
Closed

Support Sketch 45 plugin update system #7

bomberstudios opened this issue Jun 1, 2017 · 5 comments
Assignees

Comments

@bomberstudios
Copy link

Hi there!

This is a quick note to remind you that Sketch 45 will include a plugin update system.

It would be awesome if you could add support to it (it's really easy!) before Sketch 45 comes out. Ideally, you should release an update for your plugin while we're still in Sketch 44, so your users will have a nice & easy experience when 45 is released.

For more details, please check http://sketchplugins.com/d/229-updating-plugins and http://developer.sketchapp.com/introduction/updating-plugins/

Thanks in advance!

@lucaorio
Copy link
Owner

lucaorio commented Jun 1, 2017

Hey @bomberstudios, I'm just waiting for a couple free hours to fix a bug and add this new update. Thanks for the reminder! 👍

@lucaorio lucaorio self-assigned this Jun 1, 2017
@lucaorio lucaorio mentioned this issue Jul 8, 2017
@lucaorio
Copy link
Owner

lucaorio commented Jul 8, 2017

@bomberstudios I finally just pushed an update that should address this! 🎉 How to double-check that everything is working well? Should I bump the version to try?

@bomberstudios
Copy link
Author

Code looks good from here. You can test that it works by modifying an installed copy of the plugin so that its version is lower than 1.3.0, and it should update just fine.

BTW, I tried on your plugin, and the appcast URL on the plugin that can be downloaded from the releases page is pointing to a non-existing URL (https://raw.githubusercontent.com/lucaorio/sketch-styles-generator/master/.appcast.xml) when it should be pointing to https://raw.githubusercontent.com/lucaorio/sketch-styles-generator/master/.appcast.xml

If you change that, it works as expected:

screen shot 2017-07-10 at 09 47 45

@lucaorio
Copy link
Owner

Thanks a lot for the help @bomberstudios , everything works well now!

@bomberstudios
Copy link
Author

🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants