Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not contributing directly to pre-commit-hooks? #11

Closed
ssbarnea opened this issue Aug 3, 2019 · 2 comments
Closed

Why not contributing directly to pre-commit-hooks? #11

ssbarnea opened this issue Aug 3, 2019 · 2 comments

Comments

@ssbarnea
Copy link

ssbarnea commented Aug 3, 2019

I found at least one useful hook here and I am wondering why you did not contribute them directly to https://github.com/pre-commit/pre-commit-hooks ?

Adding more external dependencies increases risks and if each functionality is installed from a different repository you easily endup with a build process that is flaky and also less secure (a forced push on one of repositories, one of them being hacked,...).

@Lucas-C
Copy link
Owner

Lucas-C commented Aug 3, 2019

Answering in pre-commit/pre-commit-hooks#399

@Lucas-C Lucas-C closed this as completed Aug 3, 2019
@Lucas-C
Copy link
Owner

Lucas-C commented Aug 3, 2019

Btw, I would have appreciated a comment that you went along and already created a PR with code from this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants