Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds remove-tabs hook #399

Closed
wants to merge 1 commit into from

Conversation

ssbarnea
Copy link
Contributor

@ssbarnea ssbarnea commented Aug 3, 2019

Based on original work from https://github.com/Lucas-C/pre-commit-hooks

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious to hear what @Lucas-C thinks

pre_commit_hooks/util.py Outdated Show resolved Hide resolved
pre_commit_hooks/remove_tabs.py Outdated Show resolved Hide resolved
Inpired by initial work done by Lucas-C:
https://github.com/Lucas-C/pre-commit-hooks
@Lucas-C
Copy link
Contributor

Lucas-C commented Aug 3, 2019

@ssbarnea @asottile : the code license stays the same and I am totally fine with integrating hooks from Lucas-C/pre-commit-hooks here. I mostly agree with your comments in Lucas-C/pre-commit-hooks#11 @ssbarnea about the benefit of having hooks like this one, with no dependency to a specific language/tool, grouped in a single repo.
It will mean moving the very light support / maintenance for this hook to the maintainers of this repo, and I'm cool with that as long as @asottile & the other admins are OK.

Btw, is there an officiel position of the pre-commit core devs about this ? Do you recommend contributing to this repo instead of isolated projects ?

@ssbarnea
Copy link
Contributor Author

ssbarnea commented Aug 3, 2019

@Lucas-C Thanks! I guess it makes sense to consolidate generic mini-hooks, it makes much easier to adopt (and maintain) them.

@asottile
Copy link
Member

asottile commented Aug 4, 2019

I've had some time to think about this and while this particular hook fits the category for this repository (high quality, language-agnostic, pretty useful) I think that I'd rather celebrate @Lucas-C's contributions and continue to direct people to their many pre-commit hook repositories than cherry pick individual hooks here. In particular for this hook, it really wouldn't make sense to take it without the three+ related hooks and at that point it would really be merging another repository into this one which I don't really want to do. It's easy / trivial to add another repo to your .pre-commit-config.yaml and so I don't see the points made in Lucas-C/pre-commit-hooks#11 being valid.

Thanks again for the PR @ssbarnea but please in the future ask nicely of the author (and CC me and/or @chriskuehl) before uprooting and moving code around and especially don't do so without LICENSE / attribution

@asottile asottile closed this Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants