Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

never keep track of more than 500 ACK ranges #2029

Merged
merged 2 commits into from
Aug 5, 2019

Conversation

marten-seemann
Copy link
Member

Fixes #2010. Builds on top of #2028.

@codecov-io
Copy link

codecov-io commented Jul 30, 2019

Codecov Report

Merging #2029 into master will decrease coverage by 0.06%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2029      +/-   ##
==========================================
- Coverage   85.43%   85.37%   -0.06%     
==========================================
  Files          99       99              
  Lines        7174     7197      +23     
==========================================
+ Hits         6129     6144      +15     
- Misses        761      767       +6     
- Partials      284      286       +2
Impacted Files Coverage Δ
session.go 72.09% <100%> (+0.13%) ⬆️
internal/ackhandler/received_packet_history.go 96.97% <100%> (+0.14%) ⬆️
internal/ackhandler/received_packet_tracker.go 79.55% <100%> (-0.45%) ⬇️
internal/ackhandler/received_packet_handler.go 63.27% <80%> (ø) ⬆️
internal/handshake/qtls.go 89.47% <0%> (-1.32%) ⬇️
internal/handshake/crypto_setup.go 67.42% <0%> (-1.12%) ⬇️
internal/ackhandler/sent_packet_handler.go 75.32% <0%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320d4a8...d558562. Read the comment docs.

This is achieved by deleting the oldest ACK ranges when receiving a
packet that creates a new ACK range such that this limit is exceeded.
@marten-seemann marten-seemann merged commit d270d9c into master Aug 5, 2019
@marten-seemann marten-seemann deleted the delete-old-ack-ranges branch August 5, 2019 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is likely cause of "Too many outstanding received ACK ranges" error?
3 participants