Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework H3 ALPN handling #2090

Merged
merged 2 commits into from
Aug 31, 2019
Merged

rework H3 ALPN handling #2090

merged 2 commits into from
Aug 31, 2019

Conversation

marten-seemann
Copy link
Member

Fixes #2089.

@codecov-io
Copy link

codecov-io commented Aug 24, 2019

Codecov Report

Merging #2090 into master will decrease coverage by <.01%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2090      +/-   ##
==========================================
- Coverage   85.44%   85.43%   -<.01%     
==========================================
  Files          98       98              
  Lines        7271     7276       +5     
==========================================
+ Hits         6212     6216       +4     
  Misses        775      775              
- Partials      284      285       +1
Impacted Files Coverage Δ
http3/client.go 85% <100%> (+0.15%) ⬆️
http3/server.go 53.24% <62.5%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4621e2...328dd2c. Read the comment docs.

@mholt
Copy link
Contributor

mholt commented Aug 26, 2019

Oooo I didn't see this until just now, can't wait to try this out first thing in the morning!

@mholt
Copy link
Contributor

mholt commented Aug 26, 2019

It works!

You can view the current integration at caddyserver/caddy#2727. It's still a PoC/WIP of course.

@marten-seemann
Copy link
Member Author

@mholt Cool, thanks for testing this! Super excited to see this in Caddy soon.

@marten-seemann marten-seemann merged commit 1a6d2ad into master Aug 31, 2019
@marten-seemann marten-seemann deleted the h3-alpn-handling branch August 31, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"tls: internal error" when using GetConfigForClient
4 participants