Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't send a version negotiation packet in response to a version negotiation packet #2818

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

marten-seemann
Copy link
Member

Annoyingly, this is the bug in the QUIC spec I had discovered for the Tokyo interim meeting back in Jan 2017.

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@5d2b87e). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2818   +/-   ##
=========================================
  Coverage          ?   85.94%           
=========================================
  Files             ?      133           
  Lines             ?    12107           
  Branches          ?        0           
=========================================
  Hits              ?    10405           
  Misses            ?     1367           
  Partials          ?      335           
Impacted Files Coverage Δ
server.go 81.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d2b87e...48d25fe. Read the comment docs.

@marten-seemann marten-seemann merged commit fb22bb3 into master Oct 8, 2020
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
@marten-seemann marten-seemann deleted the server-drop-version-negotiation-packets branch March 19, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants