Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix OpenStreamSync busy looping #2827

Merged
merged 3 commits into from Oct 30, 2020

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Oct 16, 2020

Fixes #2824.

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #2827 into master will increase coverage by 0.58%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2827      +/-   ##
==========================================
+ Coverage   85.83%   86.41%   +0.58%     
==========================================
  Files         134      134              
  Lines        9036    10375    +1339     
==========================================
+ Hits         7756     8965    +1209     
- Misses        939      978      +39     
- Partials      341      432      +91     
Impacted Files Coverage Δ
streams_map_outgoing_generic.go 95.05% <75.00%> (-0.95%) ⬇️
stream.go 83.67% <0.00%> (-2.04%) ⬇️
qlog/qlog.go 95.09% <0.00%> (-0.29%) ⬇️
receive_stream.go 95.98% <0.00%> (-0.02%) ⬇️
internal/congestion/cubic.go 100.00% <0.00%> (ø)
internal/congestion/hybrid_slow_start.go 93.02% <0.00%> (+0.72%) ⬆️
internal/handshake/updatable_aead.go 96.98% <0.00%> (+0.74%) ⬆️
internal/congestion/cubic_sender.go 88.31% <0.00%> (+1.52%) ⬆️
send_stream.go 94.83% <0.00%> (+1.80%) ⬆️
http3/client.go 88.70% <0.00%> (+2.52%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598f975...5aa16eb. Read the comment docs.

@marten-seemann marten-seemann force-pushed the fix-open-stream-sync-busy-looping branch from 50e0956 to 5aa16eb Compare October 26, 2020 02:55
@MichaelMure
Copy link

Can this be reviewed? It's affecting production for us.

@marten-seemann marten-seemann merged commit b336504 into master Oct 30, 2020
@marten-seemann marten-seemann deleted the fix-open-stream-sync-busy-looping branch October 30, 2020 08:28
@MichaelMure MichaelMure mentioned this pull request Nov 20, 2020
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

busy-looping in OpenStreamSync
3 participants