Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required RouteInformationReportingType type not required #4

Closed
fredgrott opened this issue Feb 24, 2022 · 2 comments
Closed

required RouteInformationReportingType type not required #4

fredgrott opened this issue Feb 24, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@fredgrott
Copy link

In the route information provider file

{required RouteInformationReportingType type})

is no longer required on recent flutter beta and stable

Will add to this issue report if my workaround to remove mentions of that type requirement does not work.

@LucasAschenbach LucasAschenbach added the enhancement New feature or request label Feb 24, 2022
@LucasAschenbach
Copy link
Owner

LucasAschenbach commented Feb 24, 2022

Thanks for the report!
You're right, the required keyword has been removed in the latest beta. I took a brief look at the source code; it seem like this change has not made it into a stable release yet. However, if you want you can make a pull request with your changes and I will merge it as soon as the change is applied to the stable branch.

@LucasAschenbach LucasAschenbach added the waiting for response I cannot make further progress on this issue unless the original reporter responds label Feb 26, 2022
@LucasAschenbach LucasAschenbach removed the waiting for response I cannot make further progress on this issue unless the original reporter responds label May 13, 2022
@LucasAschenbach
Copy link
Owner

The API changes were now added to the stable branch with the Flutter 3 release. I've just published a new release compatible with the new API.

Thanks again for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants