Skip to content
This repository has been archived by the owner on Oct 8, 2019. It is now read-only.

Update getVideoId function #23

Merged
merged 4 commits into from
Jan 31, 2019
Merged

Update getVideoId function #23

merged 4 commits into from
Jan 31, 2019

Conversation

retyui
Copy link

@retyui retyui commented Sep 10, 2018

No description provided.

@retyui
Copy link
Author

retyui commented Oct 5, 2018

@johncblandii Will be some feedback ?

Copy link
Collaborator

@johncblandii johncblandii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thoughts in there. Good stuff overall.

src/helpers/youtube.js Outdated Show resolved Hide resolved
src/components/thumbnail.js Outdated Show resolved Hide resolved
src/helpers/youtube.test.js Show resolved Hide resolved
David Narbutovich added 3 commits October 6, 2018 21:34
Copy link
Collaborator

@johncblandii johncblandii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@retyui
Copy link
Author

retyui commented Jan 31, 2019

@johncblandii @lucasbento
There are some problems that would merge this PR?

@lucasbento lucasbento merged commit 8fa2604 into lucasbento:master Jan 31, 2019
@lucasbento
Copy link
Owner

@retyui: sorry for the extremely long delay, merged, thank you!

I'll release a new version today.

@lucasbento
Copy link
Owner

@retyui: just published a new release: https://github.com/lucasbento/react-native-thumbnail-video/releases/tag/v0.1.2.

Also invited you as a collaborator, thanks for the contributions!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants