Add type hint, model hint, and timestamp cast #69
Conversation
1. Update `phpunit.xml` to new version 2. Add all type hint 3. Add properties hint in models 4. Add casts to Carbon for timestamp field(*Breaking changes*)
|
Hi, I have found this project which suits my requirement! I'm very appreciating your work. In the process of development, I found there're some difficulties getting hints from IDE. Above PHP 8 and Laravel 9, there's a recommendation to use type hint in order to make code more readable and easily to develop. I have done them. Maybe the method hint in model is not fully supported, but it's enough to use. Many contributors and me will continue to make it more completely. Please let me know if there're any issues, and I'm looking forwards to this PR to be merged ^-^ Due to the breaking changes in timestamp type, I think maybe there should have a major version change 🤔 |
lucasdotvin
added
enhancement
|
Hello! Thanks for the contributions! I'm gonna run some tests and then merge it! 🤘 |
Codecov Report
@@ Coverage Diff @@
## develop #69 +/- ##
=============================================
- Coverage 98.20% 97.19% -1.01%
Complexity 150 150
=============================================
Files 26 26
Lines 501 499 -2
=============================================
- Hits 492 485 -7
- Misses 9 14 +5
|
phpunit.xmlto new version