fix for a skipped test _scripted_fields_filter (elastic#126866)

* fix for a skipped test * cleanup
lucasfcosta · Mar 8, 2022 · 5e3039a · 5e3039a
1 parent f00754b
commit 5e3039a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/test/functional/apps/management/_scripted_fields_filter.js b/test/functional/apps/management/_scripted_fields_filter.js
@@ -16,8 +16,7 @@ export default function ({ getService, getPageObjects }) {
   const esArchiver = getService('esArchiver');
   const PageObjects = getPageObjects(['settings']);
 
-  // FLAKY: https://github.com/elastic/kibana/issues/126027
-  describe.skip('filter scripted fields', function describeIndexTests() {
+  describe('filter scripted fields', function describeIndexTests() {
     before(async function () {
       // delete .kibana index and then wait for Kibana to re-create it
       await browser.setWindowSize(1200, 800);
@@ -67,6 +66,7 @@ export default function ({ getService, getPageObjects }) {
           expect(lang).to.be('painless');
         }
       });
+
       await PageObjects.settings.clearScriptedFieldLanguageFilter('painless');
 
       await PageObjects.settings.setScriptedFieldLanguageFilter('expression');

diff --git a/test/functional/page_objects/settings_page.ts b/test/functional/page_objects/settings_page.ts
@@ -288,7 +288,10 @@ export class SettingsPageObject extends FtrService {
   }
 
   async setScriptedFieldLanguageFilter(language: string) {
-    await this.testSubjects.clickWhenNotDisabled('scriptedFieldLanguageFilterDropdown');
+    await this.retry.try(async () => {
+      await this.testSubjects.clickWhenNotDisabled('scriptedFieldLanguageFilterDropdown');
+      return await this.find.byCssSelector('div.euiPopover__panel-isOpen');
+    });
     await this.testSubjects.existOrFail('scriptedFieldLanguageFilterDropdown-popover');
     await this.testSubjects.existOrFail(`scriptedFieldLanguageFilterDropdown-option-${language}`);
     await this.testSubjects.click(`scriptedFieldLanguageFilterDropdown-option-${language}`);