Add handling for chrome intents #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
December 28, 2018 14:54
- ensure the activity will be the start of a new task on history stack. - was running into issues on android 6.0.1 and nexus 5x android 8
|
Hi @dyihoon90 Sorry for this huge delay, your contrib seems very good. Thanks for all ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add function to handle chrome intent links, following the scheme in: Android Intents with Chrome
Context for this pull request:
We encountered a link in our react-native-webview that was opening an Android chrome intent with the "intent:" scheme.
We tried openAppWithData but realized Uri.parse only handles the "http:" scheme, so we created another method to handle intent scheme using openChromeIntent(dataUri: string, Intent.URI_INTENT_SCHEME).
More info on Intent.URI_INTENT_SCHEME.
Others:
Also added an initial index.d.ts for Typescript typing, but I didn't add much typings to the other functions.
Thanks!