Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new showCertificateExpiry in status page JSON #48

Closed
wants to merge 1 commit into from

Conversation

obfusk
Copy link

@obfusk obfusk commented Aug 21, 2023

With latest uptime kuma (v1.23.0), we get this error:

TypeError: _build_status_page_data() got an unexpected keyword argument 'showCertificateExpiry'

There are a lot more changes of course, but this is the most obvious one that breaks the API, so hopefully this is enough to make it work again even if it doesn't support all other changes. Marked as draft for now as we haven't tested it yet.

@obfusk obfusk marked this pull request as ready for review August 22, 2023 19:34
@obfusk
Copy link
Author

obfusk commented Aug 22, 2023

This fix seems to work, though obviously does not provide full support for the new version.

@lucasheld
Copy link
Owner

Uptime Kuma 1.23.1 is supported in version 1.2.0.

I decided to wait with the new release until the new version is fully supported. But I am unsure how to handle that in the future. My expectation was to wait with the Uptime Kuma update until uptime-kuma-api supports the new version.

@obfusk
Copy link
Author

obfusk commented Aug 29, 2023

This was useful to us (and perhaps others) as a quick fix for the new version breaking our ansible deploy with 1.23.0, based on a quick evaluation that nothing else we were using seemed likely to break and that this change was sufficient to get it working with the new Uptime Kuma.

But I completely understand waiting to support the new version properly, and that support was implemented fairly quickly. Thank you!

@obfusk obfusk closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants