Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Caddyfile path not set and Swarm not available logs to Debug #338

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Change Caddyfile path not set and Swarm not available logs to Debug #338

merged 1 commit into from
Feb 23, 2022

Conversation

jonatasbaldin
Copy link

Hi there!

First, thanks a lot for this project, it is very useful!

When running caddy-docker-proxy without a Caddyfile or Swarm mode enabled, the log messages below are emitted every polling interval (default for 30s).

caddy_1  | {"level":"info","ts":1645116020.518531,"logger":"docker-proxy","msg":"Skipping swarm services because swarm is not available"}
caddy_1  | {"level":"info","ts":1645116050.5464995,"logger":"docker-proxy","msg":"Skipping default Caddyfile because no path is set"}
caddy_1  | {"level":"info","ts":1645116050.54652,"logger":"docker-proxy","msg":"Skipping swarm config caddyfiles because swarm is not available"}
caddy_1  | {"level":"info","ts":1645116050.5493286,"logger":"docker-proxy","msg":"Skipping swarm services because swarm is not available"}
caddy_1  | {"level":"info","ts":1645116080.5410242,"logger":"docker-proxy","msg":"Skipping default Caddyfile because no path is set"}
...

This can be too verbose when running without a Caddyfile or Swarm. This PR changes these two log messages from Info to Debug.

I believe it offers a better user experience by avoiding emitting unnecessary logs.

@lucaslorentz lucaslorentz merged commit 7bdd39f into lucaslorentz:master Feb 23, 2022
Repository owner deleted a comment Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants