-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update windows images and try to run integration tests on windows #354
Conversation
e572561
to
17e793a
Compare
I've noticed that these checks take a long time to build, and I would guess this is due to the long time it takes to download and extract the servercore docker image. It perhaps could build faster if the base nanoserver matched the build server (matching nanoserver:1809 with windows-2019, and nanoserver:ltsc2022 with windows-2022), and then copying the netapi32 from the host itself instead of taking it from the corresponding servercore docker image. |
8040caa
to
631df9c
Compare
After MANY attempts I got integration tests running for windows, and I was able to reproduce the netapi32 error in the build server: |
@TheJayMann I will try to copy it from the build server. |
Given that Windows Server 2016 has so many limitations regarding containers, and that it is fairly unlikely that somebody will be running a semi-annual Windows Server release, I would say having the nanoserver 1809 and ltsc2022 (which is process isolation compatible with Windows Server 2019 and Windows Server 2022 long term release, respectively) is good enough, assuming the nanoserver image has netapi32 copied over. In my testing using nanoserver with netapi32 copied, there is no need to have a server core image. Given that caddy docker proxy in so far as I've seen it used typically only runs caddy and the docker proxy plugin with no other software, there is no real need to have a server core image. Were it the case that it was common to copy other applications in to the image and run them, and those applications often required server core image because it is unable to run in nanoserver, then I could see a justification for also including server core images. |
0d3cd2d
to
39ddb6b
Compare
f6f718e
to
ce2494e
Compare
Decided to not implement it that way for now because it is safer to copy from the servercore docker image. |
Update windows images, fix #333 and try to get integration tests running on windows containers