Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled Exception when running Minicover #5

Closed
mrjavaguy opened this issue Jan 17, 2018 · 2 comments
Closed

Unhandled Exception when running Minicover #5

mrjavaguy opened this issue Jan 17, 2018 · 2 comments

Comments

@mrjavaguy
Copy link

mrjavaguy commented Jan 17, 2018

dotnet minicover instrument --workdir ../ --assemblies test/**/bin/**/*.dll --sources src/**/*.cs

Instrumenting assembly "C:\dev\ims\SFMC\hubexchangegateway\test\Area.Admin.Tests\bin\Debug\netcoreapp2.0\Area.Admin.dll"

Unhandled Exception: System.Exception: Hash algorithm None is not supported.
   at MiniCover.Extensions.DocumentExtensions.CreateHashAlgorithm(DocumentHashAlgorithm algorithm)
   at MiniCover.Extensions.DocumentExtensions.FileHasChanged(Document document)
   at MiniCover.Instrumentation.Instrumenter.InstrumentAssembly(String assemblyFile)
   at MiniCover.Instrumentation.Instrumenter.Execute()
   at MiniCover.Program.<>c__DisplayClass0_0.<Main>b__1()
   at Microsoft.Extensions.CommandLineUtils.CommandLineApplication.Execute(String[] args)
   at MiniCover.Program.Main(String[] args)

Using xunit for unit tests.

Let me know what additional information you might need or how I can go about debugging this.

@lucaslorentz
Copy link
Owner

Hey, it seems that your pdb files doesn't contain hash of source files.

That shouldn't be a problem, I use that just to check if the source file was modified after compiled.

I changed the code to don't fail if there is no hash, can you please try again with new version?

MiniCover 2.0.0-ci-20180117202753

@mrjavaguy
Copy link
Author

Well that got me past this issue. So I am going to close and open a new issue.

lucaslorentz pushed a commit that referenced this issue Mar 25, 2018
* Add golden master test so we can do refactoring

* fix linux

* use last version of dotnet runtime

* Removed full path for test assembly location

* Cleaned not needed operation

* Updated approved result

* Remove ApprovalTest code and build on windows (#5)

* Remove TravisCIReporter
lucaslorentz pushed a commit that referenced this issue May 3, 2018
Fix issue with getting assembly names from dependency context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants