Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GetSourceRelativePath #32

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Conversation

bhugot
Copy link
Contributor

@bhugot bhugot commented Feb 26, 2018

Change GetSourceRelativePath so that you can have a workspace outside the path to the source file

Change GetSourceRelativePath so that you can have a workspace outside the path to the source file
.ToString()
.Replace('/', Path.DirectorySeparatorChar)
);
return relativePath;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, but there seems to be an extra space between return and relativePath

Copy link
Owner

@lucaslorentz lucaslorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucaslorentz lucaslorentz merged commit 9f70f74 into lucaslorentz:master Feb 26, 2018
@bhugot bhugot deleted the patch-1 branch March 4, 2018 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants