Add an NCover-compatible XML report output #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's awesome! I will review it later. Thanks for contributing! |
lucaslorentz
approved these changes
Jan 18, 2018
| @@ -9,16 +9,16 @@ public static void Execute(InstrumentationResult result) | |||
| { | |||
| foreach (var assembly in result.Assemblies) | |||
| { | |||
| if (File.Exists(assembly.BackupFile)) | |||
| if (File.Exists(assembly.Value.BackupFile)) | |||
There was a problem hiding this comment.
You can avoid .Value by changing the foreach to foreach (var assembly in result.Assemblies.Values)
| @@ -154,13 +157,17 @@ private void InstrumentAssembly(string assemblyFile) | |||
|
|
|||
| var instructionId = ++id; | |||
|
|
|||
| result.AddInstruction(sourceRelativePath, new InstrumentedInstruction | |||
| result.Assemblies[assemblyDefinition.Name.Name].AddInstruction(sourceRelativePath, new InstrumentedInstruction | |||
There was a problem hiding this comment.
I would prefer that the method AddInstrumentedAssembly returns the InstrumentedAssembly object.
Then we don't need to access the assembly by dictionary key here.
|
Thanks for the feedback @lucaslorentz - I made the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change the structure of the output coverage JSON to make this fit (so it's not compatible with previously-output coverage), but now people can use something like ReportGenerator to generate HTML reports :)