Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hawkular-1295 Migrate Alerts to Prometheus #1

Merged
merged 1 commit into from Nov 29, 2017

Conversation

jshaughn
Copy link

Update some entities to support alerting.

@lucasponce This PR for the client supports another PR for the provider. If you prefer not to merge these into your branch it is OK, I can wait and later add PRs against the master branches. But, this at least allows me to work against your branch for staging, since some of the live-metrics work supports the alerts work. If you do merge we can consolidate, which may be useful.

Update some entities to support alerting.
@lucasponce
Copy link
Owner

Hi Jay,
Sorry, on this repo I used a different branch.
The PR looks ok, but I need to re-arrange mine and consolidate.
I'm going to cherry-pick this commit and prepare a good hawkular-1275 branch.

@lucasponce lucasponce merged commit ba07b89 into lucasponce:hawkular-1275 Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants