New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple big improvements #31
Conversation
…emory use by 35%. Reuse server auth to make requests faster
Hi @Joolee, Thank you for this big contribution! 🙌 I've not been able to really give this app as much love as I would've liked because I'm still struggling with RSI. I will have a look at this pull request as soon as I'm back from vacation (in about a week). |
Enjoy your vacation :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Joolee overall this is looking very good, but I'd like to clarify my comment below.
Was this a mistake or an intentional change for a reason that I'm missing?
@@ -3,13 +3,8 @@ | |||
"name": "philips-jointspace", | |||
"version": "0.5.1", | |||
"dependencies": { | |||
"crypto": "^1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The crypto
dependency is still used during pairing but no longer referenced in the package.json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Homey's flavour of nodejs is compiled with support for the crypto core module, installing a third-party library from npm should not be necessary.
Though, reading the documentation, it would be probably be better to require the module with the 'node:' prefix
https://nodejs.org/api/modules.html#core-modules
https://nodejs.org/api/crypto.html#crypto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clearing things up!
Changes