Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding blur background or dim #8

Closed
TariqAlmazyad opened this issue May 27, 2021 · 3 comments · Fixed by #7
Closed

Adding blur background or dim #8

TariqAlmazyad opened this issue May 27, 2021 · 3 comments · Fixed by #7
Labels
enhancement New feature or request Thank You ❤️ For people who appreciate my work

Comments

@TariqAlmazyad
Copy link

TariqAlmazyad commented May 27, 2021

Your library is one of the best in market !
It is better to add a parameter as optional to whether choose blur bg or dim so that the focus go to the bottom sheet when user open it .
Also , make the bg dismisses the bottom sheet when user touches it .
Finally , it would be amazing to add threshold. E.g 0.234 it will dismiss ,
I almost forgot , it would be also good if you make the bottom sheet does not go above 1.0 top (passing iPhone frame)

@lucaszischka
Copy link
Owner

Thank you for you kind words and your feedback.
The feature where you tap the background to dismiss the BottomSheet is already on my list for the new version (see #7) called “tapToDismiss” and as soon as I have time I will implement it.
Just one question, what exactly do mean with:

Finally , it would be amazing to add threshold. E.g 0.234 it will dismiss

Do you mean, that when the user drags the BottomSheet down (below the threshold) the BottomSheet dismisses itself? If yes it Is also already on my #7 list called “dragToDismiss”.

The features to make the background blur and to stop the BottomSheet to go above 1 I will add on my list.

@lucaszischka lucaszischka added the enhancement New feature or request label May 27, 2021
@lucaszischka lucaszischka self-assigned this May 27, 2021
@TariqAlmazyad
Copy link
Author

TariqAlmazyad commented May 27, 2021 via email

@lucaszischka lucaszischka mentioned this issue May 27, 2021
10 tasks
@lucaszischka lucaszischka linked a pull request May 27, 2021 that will close this issue
10 tasks
@lucaszischka
Copy link
Owner

I will now close this issue because all features have been implemented and fully documented (see #7 or the branch #new version).

@lucaszischka lucaszischka mentioned this issue Jun 2, 2021
Closed
lucaszischka added a commit that referenced this issue Jul 21, 2021
This fixes #8 because it no longer relies on `.disabled()` as it uses `Introspect` instead. This is only a temporary solution, as i don't want to rely on other packages and as im planning to port my own UIScrollView to SwiftUI. The custom port would fix this issue and could make other features on my ToDo List (see #11) possible.
@lucaszischka lucaszischka added the Thank You ❤️ For people who appreciate my work label Sep 3, 2021
@lucaszischka lucaszischka removed their assignment Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Thank You ❤️ For people who appreciate my work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants