Added parent method call in _before() hook #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in: src/Codeception/Module/WordPress.php Also, fixed parsing the path for host other than localhost in: src/tad/WPBrowser/Connector/WordPress.php
This reverts commit 9608f15.
|
Thanks for opening a PR! I will look into the code when back to work next week. Same goes for the other PR. |
|
Ok :) I find this package very helpful in my current development setup, so I am going to try to contribute, if I find any rough edges to be worked around. Keep up the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the call, the dumps of requests causing failures are not saved to _output directory.
I believe other hooks also need to be reviewed in terms of the need to call parent method.