Remove argparse patch #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch is not necessary any more with python3. This allows to parse the config file only after parsing the command line.
|
@scheibler As I take from your comments in #79 the new behavior is not acceptable. The new idea I mentioned there might also fix this. So this PR will also be stalled. |
|
Included in #79. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch is not necessary any more with python3. This allows to parse the config file only after parsing the command line.
This will help with #79.
But this will change the command line interface slightly: Formally you could specify sub command options for the default command without specifying the default command on the command line. Now this is a command line parsing error. That means if
default_command=listthis used to work but doesn't any more:khard --addressbook main.I think that is acceptable.