Correct spelling of daemon. #535
Conversation
There was a problem hiding this comment.
@sbleon I agree with you, but unfortunately "APIs are forever", or at least for a very long time, and the change in core/src/main/java/lucee/runtime/tag/ThreadTag.java might break someone's code and 5.3 is already in beta.
We can put a // FUTURE remove "deamon" comment, which we usually check before working on a new version, so that we can remove it in the future.
|
Sounds good, Igal. I thought that daemon threads were a brand new feature in 5.3, but now I see that they've been around for 3 years! I agree that breaking changes should be avoided. Do you know if there's a deprecation warning mechanism in Lucee? That would be a nice thing to have, but I couldn't find anything with a quick search. |
|
@sbleon Unfortunately there is no formal process in place for deprecation. We have discussed it many times but nothing concrete came of that. We should definitely set one up though, I agree. |
|
Usually when you ask the community about deprecating anything, the only response you get is "Wait, you can't remove anything!!" :) |
|
Right, which is nonsensical if you ask me. Major versions may have breaking changes IMO, though Removal should be preceded by Deprecation first, so at least 2 major versions to remove. Python is the best example for a language that came back from the dead, and Python 3 is completely incompatible with Python 2. If they can do that, then I don't see why we can't. It will make the code cleaner and in some cases even faster, e.g. why test for a misspelled word like |
|
Having said that here... If you want to continue this discussion then let's, at the risk of starting WW3, do it in dev.lucee.org ;) |
"deamon" is a misspelling, and should not be considered valid.