Added a fix for LDEV-2412 #6
Conversation
|
we cannot simply add an exception to that method, the method has as input a default value, that means in case it can not do the job the default value is returned and never an exception is thrown. |
|
The way this pull was implemented was wrong since it ignored the default value entirely, but I still think there should be no issue throwing the exception if the default value is null (not supplied). Silent errors that don't throw an exception but simply work incorrectly are the bane of developers. As an alternative, can @cfmitrah modify every place that calls this method to pass a default value like "not found" and then if "not found" comes back, throw an exception fromm the calling code? That is more work and a worse solution in my opinion than simply throwing the exception directly, but it will work. |
|
OK, Thanks for your info. Will do the things whatever you mentioned above. |
No description provided.