Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color functionality #11

Merged
merged 24 commits into from
Jan 16, 2021
Merged

Conversation

siddarth-patil
Copy link
Contributor

Updated the "setup" file to add "numpy" dependancy.

added a optional attribute to "barplot" called "item_color" to give the ability to user to specify their own color if they want to.
Added GIF of the working example with specified colors for categories.
Added the color example with code and GIF under "example directory.

Also updated the readme file with the necessary changes
Added numpy dependancy
@lucharo
Copy link
Owner

lucharo commented Jan 15, 2021

Hi @siddarth-patil thank you so much for your PR! I've been busy at work today but I will review your PR tomorrow 😃

@siddarth-patil
Copy link
Contributor Author

Hi @lc5415 sorry for the mess above. I am new to GitHub. Below is the explanation of what I am trying to do. It might help you fix the issue.

The code ran fine on my machine as it has Python 3.8 installed and the latest version of numpy as well. The issue is in the setup.py file when I tried to add "numpy" dependency it worked fine for versions 3.7 and 3.8 but it didn't work for version 3.6. The reason is that numpy v1.20 and above has stopped supporting Python version 3.6. So, I tried to define platform specific dependencies in setup.py file as mentioned in the documentation here.

But it still failed to work. I will call it a day for now. And will look into the matter tomorrow.

An alternative which I could come up for this problem would be defining a requirements file and mention numpy there.

Please have a look into it.

setup.py Outdated Show resolved Hide resolved
…t numpy does not support py3.6 anymore

incorporated the readme example from @siddarth-patil into a test which runs succesfully
@lucharo
Copy link
Owner

lucharo commented Jan 16, 2021

Hi @lc5415 sorry for the mess above. I am new to GitHub. Below is the explanation of what I am trying to do. It might help you fix the issue.

The code ran fine on my machine as it has Python 3.8 installed and the latest version of numpy as well. The issue is in the setup.py file when I tried to add "numpy" dependency it worked fine for versions 3.7 and 3.8 but it didn't work for version 3.6. The reason is that numpy v1.20 and above has stopped supporting Python version 3.6. So, I tried to define platform specific dependencies in setup.py file as mentioned in the documentation here.

But it still failed to work. I will call it a day for now. And will look into the matter tomorrow.

An alternative which I could come up for this problem would be defining a requirements file and mention numpy there.

Please have a look into it.

Also well done on your PR, learning git + github is a bit of a steep curve at the beginning but you will gain so much in the long run. Next time try to run tests locally and try to decrease the number of commits you do!

@lucharo lucharo merged commit 881d450 into lucharo:main Jan 16, 2021
@siddarth-patil
Copy link
Contributor Author

Thanks a lot for your support.

@lucharo
Copy link
Owner

lucharo commented Jan 17, 2021

Thanks to you for the PR @siddarth-patil !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants