[milo] fix tests on windows.

The symlink to the 'templates' folder doesn't work when running the tests
on windows. Instead change the tests to load them from their true location
directly.

R=hinoka@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2955783002

milo/build_source/buildbot/html_test.go

@@ -44,7 +44,7 @@ func request(c context.Context, params map[string]string) *router.Context {
 func TestHtml(t *testing.T) {
 	c := memory.UseWithAppID(context.Background(), "dev~luci-milo")
 	c, _ = testclock.UseTime(c, testclock.TestTimeUTC)
-	c = templates.Use(c, common.GetTemplateBundle("../../frontend/templates"))
+	c = templates.Use(c, common.GetTemplateBundle("../../frontend/appengine/templates"))
 	c = auth.WithState(c, &authtest.FakeState{Identity: identity.AnonymousIdentity})
 	putDSMasterJSON(c, &buildbotMaster{
 		Name:     "fake",

milo/build_source/swarming/README.md

@@ -4,8 +4,6 @@
 * build_test.go - Tests for build.go
 * buildLog.go - Displays build logs
 * memoryClient.go - In memory butler client for annotee
-* templates - Symlink to ../frontend/templates.  Needed for tests.
-* testdata - Symlink to ../frontend/testdata.  Needed for tests.
 
 * html.go - Plain ol' html endpoints
 

milo/build_source/swarming/html_test.go

@@ -41,7 +41,7 @@ func requestCtx(c context.Context, params ...httprouter.Param) *router.Context {
 func TestHtml(t *testing.T) {
 	c := memory.UseWithAppID(context.Background(), "dev~luci-milo")
 	c, _ = testclock.UseTime(c, testclock.TestTimeUTC)
-	c = templates.Use(c, common.GetTemplateBundle("../../frontend/templates"))
+	c = templates.Use(c, common.GetTemplateBundle("../../frontend/appengine/templates"))
 	c = auth.WithState(c, &authtest.FakeState{Identity: identity.AnonymousIdentity})
 
 	Convey(`HTML handler tests`, t, func() {

milo/frontend/appengine/main.go

@@ -4,8 +4,10 @@
 
 package appengine
 
-import "github.com/luci/luci-go/milo/frontend"
+import (
+	"github.com/luci/luci-go/milo/frontend"
+)
 
 func init() {
-	frontend.Run()
+	frontend.Run("templates")
 }

milo/frontend/main.go

@@ -30,12 +30,12 @@ func emptyPrelude(c context.Context, methodName string, req proto.Message) (cont
 }
 
 // Where it all begins!!!
-func Run() {
+func Run(templatePath string) {
 	// Register plain ol' http handlers.
 	r := router.New()
 	gaemiddleware.InstallHandlers(r)
 
-	basemw := common.Base("templates")
+	basemw := common.Base(templatePath)
 	r.GET("/", basemw, frontpageHandler)
 
 	// Admin and cron endpoints.

milo/frontend/main_test.go

@@ -94,7 +94,7 @@ func TestPages(t *testing.T) {
 		c = settings.Use(c, settings.New(&settings.MemoryStorage{Expiration: time.Second}))
 		err := settings.Set(c, "analytics", &analyticsSettings{"UA-12345-01"}, "", "")
 		So(err, ShouldBeNil)
-		c = templates.Use(c, common.GetTemplateBundle("templates"))
+		c = templates.Use(c, common.GetTemplateBundle("appengine/templates"))
 		for _, p := range allPackages {
 			Convey(fmt.Sprintf("Testing handler %q", p.DisplayName), func() {
 				for _, b := range p.Data() {