Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue Warp Migration #30

Closed
clintnetwork opened this issue Nov 27, 2019 · 4 comments
Closed

Continue Warp Migration #30

clintnetwork opened this issue Nov 27, 2019 · 4 comments
Assignees
Milestone

Comments

@clintnetwork
Copy link
Member

@clintnetwork clintnetwork commented Nov 27, 2019

Hey @CephalonRho,

I really enjoy the work that you do to migrate on warp, but we need to reimplement some minor stuff, it's the reason why I do this issue!

From Nickel migration

  • Display the WebUI (located in webui/dist) for the / route~[feb452c]
  • Re-Implement CORS (just the base to consume the API from the WebUI) [2c7a3e4]
  • Set the server response header
  • Implement Server requests logging [f3bf3cd]

New stuffs

  • Implement HTTPS support [#32]
  • Rename "warp drive engaged"
  • Graceful shutdown

If you want to achieve this, you can re-use the warp-migration branch.

Best regards

@clintnetwork clintnetwork added this to the pre-alpha milestone Nov 27, 2019
@clintnetwork clintnetwork added this to Issues in Lucid Development via automation Nov 27, 2019
@clintnetwork clintnetwork added the API label Nov 27, 2019
@clintnetwork clintnetwork self-assigned this Nov 28, 2019
@clintnetwork

This comment has been minimized.

Copy link
Member Author

@clintnetwork clintnetwork commented Dec 30, 2019

@CephalonRho

Now we have warp::serve(routes).bind() is it possible to replace with bind_with_graceful_shutdown?

Cheers

@CephalonRho

This comment has been minimized.

Copy link
Member

@CephalonRho CephalonRho commented Dec 30, 2019

Sure, there shouldn't be a problem just replacing it with bind_with_graceful_shutdown and adding a shutdown channel. I'm not sure how we would trigger it though, to me it seems like it's is meant to give the program the ability to shut down only the warp server and explicitly clean up resources afterwards, so this would only be useful when adding persistence later.

Lucid seems to shut down gracefully enough right now, I don't get any error when stopping it with SIGINT on Linux.

@clintnetwork

This comment has been minimized.

Copy link
Member Author

@clintnetwork clintnetwork commented Dec 30, 2019

Oh for the error I don't have too, only when it's in debug, but it's not really important.

If we can use bind_with_graceful_shutdown I think it's better

@clintnetwork

This comment has been minimized.

Copy link
Member Author

@clintnetwork clintnetwork commented Dec 30, 2019

For the explicit cleanup, it's interesting, I will think about that

@clintnetwork clintnetwork mentioned this issue Jan 1, 2020
15 of 17 tasks complete
@clintnetwork clintnetwork modified the milestones: pre-alpha, alpha Jan 2, 2020
Lucid Development automation moved this from Issues to Jobs Done Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Lucid Development
  
Jobs Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.