Continue Warp Migration

[imclint21]

Hey @CephalonRho,

I really enjoy the work that you do to migrate on warp, but we need to reimplement some minor stuff, it's the reason why I do this issue!

From Nickel migration

• Display the WebUI (located in webui/dist) for the / route~[feb452c]
• Re-Implement CORS (just the base to consume the API from the WebUI) [2c7a3e4]
• Set the server response header
• Implement Server requests logging [f3bf3cd]

New stuffs

• Implement HTTPS support [Implement HTTPS support #32]
• Rename "warp drive engaged"
• Graceful shutdown

If you want to achieve this, you can re-use the warp-migration branch.

Best regards

[imclint21]

@CephalonRho

Now we have warp::serve(routes).bind() is it possible to replace with bind_with_graceful_shutdown?

Cheers

[shuni64]

Sure, there shouldn't be a problem just replacing it with bind_with_graceful_shutdown and adding a shutdown channel. I'm not sure how we would trigger it though, to me it seems like it's is meant to give the program the ability to shut down only the warp server and explicitly clean up resources afterwards, so this would only be useful when adding persistence later.

Lucid seems to shut down gracefully enough right now, I don't get any error when stopping it with SIGINT on Linux.

[imclint21]

Oh for the error I don't have too, only when it's in debug, but it's not really important.

If we can use bind_with_graceful_shutdown I think it's better

[imclint21]

For the explicit cleanup, it's interesting, I will think about that