Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTTPS support #32

Merged
merged 6 commits into from
Nov 30, 2019
Merged

Implement HTTPS support #32

merged 6 commits into from
Nov 30, 2019

Conversation

imclint21
Copy link
Member

@imclint21 imclint21 commented Nov 29, 2019

Hey,

This is the implementation of TLS with warp.

Please, @CephalonRho just look if you see mistake :)

PS: It could be good to have a double bind, on SSL and not.

Best regards

@imclint21 imclint21 added enhancement New feature or request core Core development labels Nov 29, 2019
@imclint21 imclint21 added this to the pre-alpha milestone Nov 29, 2019
@imclint21 imclint21 self-assigned this Nov 29, 2019
@imclint21 imclint21 added this to Works in Progress in Lucid Development via automation Nov 29, 2019
@imclint21 imclint21 requested a review from Slals November 29, 2019 17:18
@imclint21 imclint21 mentioned this pull request Nov 29, 2019
7 tasks
Copy link
Contributor

@shuni64 shuni64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Having the ability to bind to multiple ports at the same time (with and without tls enabled) should definitely be possible too, but this is a good first implementation. It breaks existing configurations, but that's because of the way we handle configuration changes and is necessary here.

@imclint21
Copy link
Member Author

For the configuration part, do you have an idea? maybe we can set a parameter to skip missing fields or others.

This is the missing parameter in your configuration (for information):

ssl_certificate: "tls/cert.pem"
ssl_certificate_key: "tls/key.rsa"

@shuni64
Copy link
Contributor

shuni64 commented Nov 29, 2019

For the configuration problems, we could just always fill in the missing fields with values from the default configuration. As far as I know it should be a good way to handle it, we already have a way to force-regenerate the configuration file too.

It's not directly related to this PR though and can be done later.

@imclint21
Copy link
Member Author

Hmm yes, I also would like to do #22

@imclint21 imclint21 removed the request for review from Slals November 30, 2019 21:45
@imclint21 imclint21 merged commit c33c6ea into master Nov 30, 2019
Lucid Development automation moved this from Works in Progress to Jobs Done Nov 30, 2019
@imclint21 imclint21 deleted the https-support branch December 1, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core development enhancement New feature or request
Projects
Lucid Development
  
Jobs Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants