-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HTTPS support #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Having the ability to bind to multiple ports at the same time (with and without tls enabled) should definitely be possible too, but this is a good first implementation. It breaks existing configurations, but that's because of the way we handle configuration changes and is necessary here.
For the configuration part, do you have an idea? maybe we can set a parameter to skip missing fields or others. This is the missing parameter in your configuration (for information): ssl_certificate: "tls/cert.pem"
ssl_certificate_key: "tls/key.rsa" |
For the configuration problems, we could just always fill in the missing fields with values from the default configuration. As far as I know it should be a good way to handle it, we already have a way to force-regenerate the configuration file too. It's not directly related to this PR though and can be done later. |
Hmm yes, I also would like to do #22 |
Hey,
This is the implementation of TLS with
warp
.Please, @CephalonRho just look if you see mistake :)
PS: It could be good to have a double bind, on SSL and not.
Best regards