Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging #49

Merged
merged 11 commits into from
Jan 31, 2020
Merged

Improve logging #49

merged 11 commits into from
Jan 31, 2020

Conversation

imclint21
Copy link
Member

@imclint21 imclint21 commented Jan 5, 2020 •
edited
Loading

Hi,

  • Add colored logs as an option
  • Create output log file (in /var/log/ under Unix)
  • Broadcast to stderr for warning or error entries
  • Add syslog support

Best regards

@imclint21 imclint21 added enhancement New feature or request help wanted Extra attention is needed labels Jan 5, 2020
@imclint21 imclint21 added this to the alpha milestone Jan 5, 2020
@imclint21 imclint21 added this to Works in Progress in Lucid Development via automation Jan 5, 2020
@imclint21 imclint21 added outdated and removed help wanted Extra attention is needed labels Jan 21, 2020
@imclint21 imclint21 mentioned this pull request Jan 21, 2020
Closed
@imclint21
Copy link
Member Author

imclint21 commented Jan 21, 2020 •
edited
Loading

This PR is outdated right now, I need to fix conflicts.

@imclint21 imclint21 mentioned this pull request Jan 22, 2020
Open
@imclint21
Copy link
Member Author

imclint21 commented Jan 31, 2020 •
edited
Loading

Hi, can I merge @CephalonRho?

@imclint21 imclint21 requested a review from Slals January 31, 2020 09:38
@shuni64
Copy link
Contributor

shuni64 commented Jan 31, 2020

If you're fine with no syslog integration for now then yeah, go ahead. I didn't want to introduce portability problems with Windows again, so I wanted to understand how fern uses syslog first.

@imclint21
Copy link
Member Author

Yeah you right, and apparently fern has some problems with Syslog (about version by example, etc)

Alright, I merge it!

@imclint21 imclint21 merged commit 9ca0fff into master Jan 31, 2020
Lucid Development automation moved this from Works in Progress to Jobs Done Jan 31, 2020
@imclint21 imclint21 deleted the improve-logs branch January 31, 2020 10:31
@imclint21 imclint21 linked an issue Mar 10, 2020 that may be closed by this pull request
[Roadmap][Alpha] Lucid Alpha Roadmap #46
Closed
15 tasks
@imclint21 imclint21 removed a link to an issue Mar 10, 2020
[Roadmap][Alpha] Lucid Alpha Roadmap #46
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuni64 shuni64 shuni64 approved these changes

@Slals Slals Awaiting requested review from Slals

Assignees

@imclint21 imclint21

@shuni64 shuni64

Labels
enhancement New feature or request outdated
Projects
Lucid Development
  
Jobs Done
Milestone
alpha
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imclint21 @shuni64