Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lucide.d.ts gives me multiple errors #1760

Closed
4 of 25 tasks
AetherDim opened this issue Dec 27, 2023 · 3 comments
Closed
4 of 25 tasks

lucide.d.ts gives me multiple errors #1760

AetherDim opened this issue Dec 27, 2023 · 3 comments
Labels
🐛 bug Something isn't working

Comments

@AetherDim
Copy link

Package

  • lucide
  • lucide-angular
  • lucide-flutter
  • lucide-preact
  • lucide-react
  • lucide-react-native
  • lucide-solid
  • lucide-svelte
  • lucide-vue
  • lucide-vue-next
  • Figma plugin
  • source/main
  • other/not relevant

Version

0.302.0

Browser

  • Chrome/Chromium
  • Firefox
  • Safari
  • Edge
  • iOS Safari
  • Opera
  • Other/not relevant

Operating system

  • Windows
  • Linux
  • macOS
  • Other/not relevant

Description

Type checking my project gives me multiple errors from lucide-preact.d.ts.

image

(This is a screenshot from my Jetbrains IDE, but my VSCode setup reports the issues as well)

Steps to reproduce

Install lucide-preact.

Open the lucide-preact.d.ts and run a type check.

image

Checklist

  • I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)
@AetherDim AetherDim added the 🐛 bug Something isn't working label Dec 27, 2023
@Ashish1-Sharma
Copy link

import { ReactSVG } from 'some-library'; // Adjust based on your actual library

@AetherDim
Copy link
Author

AetherDim commented Dec 31, 2023

import { ReactSVG } from 'some-library'; // Adjust based on your actual library

I don't think preact has an SVG type. Everything works fine when I choose to ignore the errors.

The ReactSVG error can be suppressed by doing something like:

type ReactSVG = {}

But the other type errors are not affected because the d.ts file has duplicate type definitions for some elements.

@ericfennis
Copy link
Member

ericfennis commented Jan 4, 2024

This is fixed in #1773.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants