Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Requests from Feather] file-zip #606

Closed
karsa-mistmere opened this issue Apr 22, 2022 · 7 comments · Fixed by #736
Closed

[Icon Requests from Feather] file-zip #606

karsa-mistmere opened this issue Apr 22, 2022 · 7 comments · Fixed by #736

Comments

@karsa-mistmere
Copy link
Member

As per #119 and feathericons/feather#339:

image
file-zip

@ericfennis
Copy link
Member

@karsa-mistmere Nice, I think the zipper can be bigger. Maybe somethink like the github icons?
image

@karsa-mistmere
Copy link
Member Author

Yeah, the github icon looks nice, but doesn't quite fit well with the rest of the file icons.

@karsa-mistmere
Copy link
Member Author

Here are the latest drafts. I think the best solution may very well be the simplest?...
image
image

@ericfennis
Copy link
Member

@karsa-mistmere What do you think of these ones?
image
image

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented May 30, 2022

All the rest of the file icons use a straight line in case an inset item breaks the outline (e.g. file-digit or file-search), I think we should keep that uniform between file icons.
I like the first, but I'd either keep the slider rectangular or maybe even completely round?
image
zip

I'm not really into breaking the guidelines, but I actually think maybe out of all of these many many icons so far, it's the third one that looks best. 😅

@ericfennis
Copy link
Member

Yeah I had something like this as well, but the bottom left corner bothered me a bit. But maybe that's me.
I think I like the first one and the second one the most.

So maybe we need a second opinion. 😛

@karsa-mistmere
Copy link
Member Author

Or we could split the difference and go with the 2nd, since that seems to be the most common ground so far. :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants