-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds various badge
icons, rebases verified
as badge-check
#1118
Adds various badge
icons, rebases verified
as badge-check
#1118
Conversation
This reverts commit 49bd49b.
…con-api-route-issue' into badge-verified
Co-authored-by: Jakob Guddas <github@jguddas.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericfennis: well, in comparison to Twitter maybe, but in comparison to our own |
I think the circle is too big in that instance 😅 |
@jguddas: well, If anything, the checkmark may be too small, compared to FA the proposed new base shape is much more in line (top FA, bottom PR): |
(me 😅) I get that… But I think the crux of it is that |
Well, that's the exactly the point. Squares have a smaller visual weight than circles. 🙂 |
If anything than it's the square that's to big. |
Sure, but I mean in terms of trying to fit the same elements nicely inside both is problematic :) |
Oh, but you're forgetting the 2px rounding!😄 |
Oh that's right 😄 @karsa-mistmere. We are not super consistent when we look at the convex hull to compare visual weight. |
@jguddas: Yeah definitely have some outliers, but we should certainly strive for consistency. :) Also, convex hull is a nice metric, but not necessarily the best measure of visual weight, see the article above. |
closes #1109 #1073
Addresses some leftover comments from #416 and renames
verified
to bebadge-check
while also adding its base shape.Also makes the shape more consistent in size with
circle
.Also adds feathericons/feather#865 as part of #119