Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add radiation/biohazard icons #1153

Merged
merged 6 commits into from
Apr 30, 2023
Merged

Conversation

danielbayley
Copy link
Member

Alternatives:
Untitled

@github-actions
Copy link

github-actions bot commented Apr 24, 2023

Added or changed icons

Icon X-rays icons/biohazard.svg icons/radiation.svg

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Apr 24, 2023

How about something like the 2nd row but with no rounding?
image

While in general, round corners fit the Lucide aesthetic more, I think in this instance it causes the well established shape to lose character.

@jguddas
Copy link
Member

jguddas commented Apr 24, 2023

I don't like the sharp corners and the big circle that doesn't have a 2px whole in it in the center.

@jguddas
Copy link
Member

jguddas commented Apr 24, 2023

I think this one is the best, but maybe a bit smaller with a less pronounced radius? image

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Apr 25, 2023

I think this one is the best, but maybe a bit smaller with a less pronounced radius? image

That's not bad, but yeah, maybe let's try a somewhat smaller corner radius and larger gap between the segments and the central dot.

@danielbayley
Copy link
Member Author

larger gap between the segments and the central dot.

Yeah that was a rules violation. What do we think between these…?

Untitled

Untitled

@jguddas
Copy link
Member

jguddas commented Apr 25, 2023

I prefer the right one.

@danielbayley
Copy link
Member Author

I prefer the right one.

Same…

@karsa-mistmere
Copy link
Member

I would love to also have a matching biohazard icon, but this is just not compliant, I'm afraid. 😅
biohazard

@jguddas
Copy link
Member

jguddas commented Apr 25, 2023

Looks nice and compliant to me. icon (28)

@danielbayley danielbayley changed the title Add radiation icon Add radiation/biohazard icons Apr 25, 2023
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice icons!

@karsa-mistmere karsa-mistmere merged commit 716c5ba into lucide-icons:main Apr 30, 2023
3 checks passed
@danielbayley danielbayley deleted the radiation branch April 30, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants