Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add book-* icons #1352

Merged
merged 51 commits into from
Oct 17, 2023
Merged

Add book-* icons #1352

merged 51 commits into from
Oct 17, 2023

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented Jun 9, 2023

  • book-a is dictionary, but could also be fonts/library
  • book-type is fonts/library, but also can be thesaurus
  • book-check is already read/finished, or purchased (e.g reading list/shopping/cart)
  • book-heart is diary/journal, but also favourite (again list/review etc)
  • book-image is photos/album
  • book-tabs/user is contacts/address book (can also be diary/journal)
  • book-spine variant can be hardback (vs just book as paperback… again use case is reading list/shopping/cart)
  • book-audio/volume/headphones are obviously audiobook variants (again for reading list/shopping/cart)

Closely related to #1363.

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Added or changed icons

icons/book-a.svg icons/book-audio.svg icons/book-check.svg icons/book-dashed.svg icons/book-headphones.svg icons/book-heart.svg icons/book-image.svg icons/book-open-text.svg icons/book-text.svg icons/book-type.svg icons/book-user.svg icons/library-big.svg icons/library-square.svg

Preview cohesion icons/x-square.svg icons/terminal-square.svg icons/message-square.svg icons/arrow-down-square.svg icons/square.svg icons/square-dashed-bottom-code.svg icons/kanban-square-dashed.svg icons/scissors-square.svg icons/kanban-square.svg icons/activity-square.svg icons/library-square.svg icons/parking-square.svg icons/arrow-down-left-square.svg
icons/book-a.svg icons/book-audio.svg icons/book-check.svg icons/book-dashed.svg icons/book-headphones.svg icons/book-heart.svg icons/book-image.svg icons/book-open-text.svg icons/book-text.svg icons/book-type.svg icons/book-user.svg icons/library-big.svg icons/library-square.svg
icons/satellite-dish.svg icons/corner-left-up.svg icons/music-3.svg icons/laptop.svg icons/slash.svg icons/cloud-hail.svg icons/pocket.svg icons/arrow-down-z-a.svg icons/calendar-x.svg icons/umbrella-off.svg icons/file-scan.svg icons/parking-circle-off.svg icons/file-box.svg
Preview stroke widths icons/book-a.svg icons/book-audio.svg icons/book-check.svg icons/book-dashed.svg icons/book-headphones.svg icons/book-heart.svg icons/book-image.svg icons/book-open-text.svg icons/book-text.svg icons/book-type.svg icons/book-user.svg icons/library-big.svg icons/library-square.svg
icons/book-a.svg icons/book-audio.svg icons/book-check.svg icons/book-dashed.svg icons/book-headphones.svg icons/book-heart.svg icons/book-image.svg icons/book-open-text.svg icons/book-text.svg icons/book-type.svg icons/book-user.svg icons/library-big.svg icons/library-square.svg
icons/book-a.svg icons/book-audio.svg icons/book-check.svg icons/book-dashed.svg icons/book-headphones.svg icons/book-heart.svg icons/book-image.svg icons/book-open-text.svg icons/book-text.svg icons/book-type.svg icons/book-user.svg icons/library-big.svg icons/library-square.svg
DPI Preview (24px) icons/book-a.svg icons/book-audio.svg icons/book-check.svg icons/book-dashed.svg icons/book-headphones.svg icons/book-heart.svg icons/book-image.svg icons/book-open-text.svg icons/book-text.svg icons/book-type.svg icons/book-user.svg icons/library-big.svg icons/library-square.svg
Icon X-rays icons/book-a.svg icons/book-audio.svg icons/book-check.svg icons/book-dashed.svg icons/book-headphones.svg icons/book-heart.svg icons/book-image.svg icons/book-open-text.svg icons/book-text.svg icons/book-type.svg icons/book-user.svg icons/library-big.svg icons/library-square.svg

Remove detail.
@danielbayley danielbayley changed the title Add book-*/note[*] icons Add [note]book/pad[-*] icons Jun 9, 2023
@github-actions github-actions bot removed the 🌍 site Has to do something with the Lucide website label Jun 26, 2023
@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 20, 2023
@ericfennis
Copy link
Member

ericfennis commented Sep 6, 2023

Ok let's priotize some icons.
Let's go for:

  • book-a
  • book-audio
  • book-check
  • book-dashed
  • book-elastic, Usecase feels not really solid
  • book-git-commit, The commit icon is to small and not really regognisable
  • book-headphones
  • book-heart
  • book-image
  • book-open-2
  • book-open-text
  • book-spine, Looks a bit weird to me on 100%
  • book-tabs, Looks a bit weird to me on 100%
  • book-text
  • book-type
  • book-user
  • book-volume, I still see a book with wifi icon, I know we use this as well on file-volumde, we need to change that one as well.
  • library-big
  • library-square

Edited the list based on the @karsa-mistmere comment below

@karsa-mistmere
Copy link
Member

I'm also against adding book-open-2, for several reasons:

  1. bad naming scheme
  2. lack of unique use case as compared to book-open
  3. this one would again make it look like we can't make up our mind about what a Lucide style open book icon should look like. We should either stick with the current one or replace it, not add various alts.

@github-actions github-actions bot removed the Stale label Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 7, 2023
@ericfennis ericfennis merged commit 4f5642b into lucide-icons:main Oct 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants