Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons/outlined #1530

Closed
wants to merge 6 commits into from
Closed

Icons/outlined #1530

wants to merge 6 commits into from

Conversation

Heahl
Copy link

@Heahl Heahl commented Aug 24, 2023

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other

Description

Added kununu and Xing Icons

Icon use case

For social buttons, I can't think of more use cases. Should be reasonable enough, though.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

added xing-outlined.svg, that follows the lucide design guide principles.
added the .json for the already added .svg file
Added .json for kununu-outlined.svg
added kununu-outlined.svg in compliance with the guidelines
@github-actions github-actions bot added the 🫧 metadata Improved metadata label Aug 24, 2023
@Heahl
Copy link
Author

Heahl commented Aug 24, 2023

What can I improve @karsa-mistmere ?

@karsa-mistmere
Copy link
Member

What can I improve @karsa-mistmere ?

We do not accept brand icons: #670

@Heahl
Copy link
Author

Heahl commented Aug 24, 2023 via email

@karsa-mistmere
Copy link
Member

#670 #94

@Heahl
Copy link
Author

Heahl commented Aug 24, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants