-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons/outlined #1530
Closed
Closed
Icons/outlined #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added xing-outlined.svg, that follows the lucide design guide principles.
added the .json for the already added .svg file
Added .json for kununu-outlined.svg
added kununu-outlined.svg in compliance with the guidelines
What can I improve @karsa-mistmere ? |
We do not accept brand icons: #670 |
You mean you don’t accept specific brand icons? Because there are already twenty in your DB. So what is wrong with these two? @karsa-mistmere ?
…________________________________
Von: Karsa ***@***.***>
Gesendet: Thursday, August 24, 2023 6:22:41 PM
An: lucide-icons/lucide ***@***.***>
Cc: Heahl ***@***.***>; Author ***@***.***>
Betreff: Re: [lucide-icons/lucide] Icons/outlined (PR #1530)
What can I improve @karsa-mistmere<https://github.com/karsa-mistmere> ?
We do not accept brand icons: #670<#670>
—
Reply to this email directly, view it on GitHub<#1530 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2VJRZFGMWL63GMCPRLX4BDXW55VDANCNFSM6AAAAAA35B6YWQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Ah sry, just read the issue #670. Still don’t understand the decision. Can you give me a short reasoning for that?
…________________________________
Von: H A ***@***.***>
Gesendet: Thursday, August 24, 2023 10:04:15 PM
An: lucide-icons/lucide ***@***.***>; lucide-icons/lucide ***@***.***>
Cc: Author ***@***.***>
Betreff: Re: [lucide-icons/lucide] Icons/outlined (PR #1530)
You mean you don’t accept specific brand icons? Because there are already twenty in your DB. So what is wrong with these two? @karsa-mistmere ?
________________________________
Von: Karsa ***@***.***>
Gesendet: Thursday, August 24, 2023 6:22:41 PM
An: lucide-icons/lucide ***@***.***>
Cc: Heahl ***@***.***>; Author ***@***.***>
Betreff: Re: [lucide-icons/lucide] Icons/outlined (PR #1530)
What can I improve @karsa-mistmere<https://github.com/karsa-mistmere> ?
We do not accept brand icons: #670<#670>
—
Reply to this email directly, view it on GitHub<#1530 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2VJRZFGMWL63GMCPRLX4BDXW55VDANCNFSM6AAAAAA35B6YWQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
Added kununu and Xing Icons
Icon use case
For social buttons, I can't think of more use cases. Should be reasonable enough, though.
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting