Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lucide-angular] Simplified LucideIconData #1641

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

karsa-mistmere
Copy link
Member

What is the purpose of this pull request?

  • Other: code optimization

Description

This PR refactors lucide-angular's LucideIconData interface to only include child nodes. A base svg node name and the defaultAttributes are no longer part of the icon node format, since they should be added to every icon anyway by LucideAngularComponent, e.g.:

// Current format
const Activity: LucideIconData = [
  'svg',
  defaultAttributes,
  [['path', { d: 'M22 12h-4l-3 9L9 3l-3 9H2', key: 'd5dnw9' }]],
];

// New icon node format
const Activity: LucideIconData = [
  ['path', { d: 'M22 12h-4l-3 9L9 3l-3 9H2', key: 'd5dnw9' }],
];

Before Submitting

@karsa-mistmere karsa-mistmere added the 🅰️ angular package About the Angular package label Oct 27, 2023
@github-actions github-actions bot removed the 🅰️ angular package About the Angular package label Oct 27, 2023
@karsa-mistmere karsa-mistmere added the 🅰️ angular package About the Angular package label Oct 27, 2023
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @karsa-mistmere !

@ericfennis ericfennis merged commit c5804ad into main Oct 31, 2023
3 checks passed
@ericfennis ericfennis deleted the feat/angular-icon-data-refactor branch October 31, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🅰️ angular package About the Angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants