Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clipboard-plus and clipboard-minus icons #1812

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

ericfennis
Copy link
Member

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adding clipboard-plus and clipboard-minus.

Icon use case

  • Adding something to the clipboard
  • clipboard-plus could be used for medical use cases (not ideal), like doctor reports.
  • Removing something from the clipboard

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 17, 2024
Copy link

github-actions bot commented Jan 17, 2024

Added or changed icons

icons/clipboard-minus.svgicons/clipboard-plus.svg

Preview cohesion icons/message-square-off.svgicons/scissors-square-dashed-bottom.svg
icons/clipboard-minus.svgicons/clipboard-plus.svg
icons/arrow-big-left.svgicons/soup.svg
Preview stroke widths icons/clipboard-minus.svgicons/clipboard-plus.svg
icons/clipboard-minus.svgicons/clipboard-plus.svg
icons/clipboard-minus.svgicons/clipboard-plus.svg
DPI Preview (24px) icons/clipboard-minus.svgicons/clipboard-plus.svg
Icon X-rays icons/clipboard-minus.svgicons/clipboard-plus.svg

@jguddas
Copy link
Member

jguddas commented Jan 17, 2024

Do we have a standard plus and minus size, feels a bit big.

@ericfennis
Copy link
Member Author

@jguddas I've based these ones on the plus-square icons.

@ericfennis
Copy link
Member Author

The plus from file-plus is also an option.
image

100%
plus

icons/clipboard-minus.json Outdated Show resolved Hide resolved
@karsa-mistmere
Copy link
Member

I agree with @jguddas, the plus and minus signs feel a bit too large, almost all of our other *-plus icons use a 6 by 6 plus (other than a few outliers such as square-plus and circle-plus which have plenty of space to accommodate for larger signs, and calendar-plus that uses a tiny one):
image

@ericfennis
Copy link
Member Author

@karsa-mistmere Sorry forgot to post an update on this.
Already added the smaller plus. The one that is selected in my previous post. That is the plus from the file icon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also decrease the plus size on shield-plus to match? 🤔
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yess, will do in a separate PR!

@ericfennis ericfennis merged commit 713e9b8 into lucide-icons:main Jan 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants