Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounded corners of graduation-cap icon #1870

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Feb 10, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other: Optimization

Description

Trying out https://lucide-studio.vercel.app

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Feb 10, 2024
Copy link

github-actions bot commented Feb 10, 2024

Added or changed icons

icons/graduation-cap.svg

Preview cohesion icons/messages-square.svg
icons/graduation-cap.svg
icons/alarm-clock.svg
Preview stroke widths icons/graduation-cap.svg
icons/graduation-cap.svg
icons/graduation-cap.svg
DPI Preview (24px) icons/graduation-cap.svg
Icon X-rays icons/graduation-cap.svg

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Feb 10, 2024

I wonder, should we not add rounding to the corners as in layers? 🤔

image

@jguddas
Copy link
Member Author

jguddas commented Feb 10, 2024

I wonder, should we not add rounding to the corners as in layers? 🤔

image

Round looks better to me.

@jguddas jguddas changed the title Optimized graduation-cap icon Rounded corners of graduation-cap icon Feb 10, 2024
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this one better!

@karsa-mistmere karsa-mistmere merged commit 981c330 into lucide-icons:main Feb 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants