Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon-component): Creating icons with iconNodes #1997

Merged
merged 36 commits into from
Apr 26, 2024

Conversation

ericfennis
Copy link
Member

@ericfennis ericfennis commented Mar 18, 2024

contributes to #1687

What is the purpose of this pull request?

  • New Feature

Todo

  • Lucide React
  • Lucide Preact
  • Lucide React Native
  • Lucide Vue Next
  • Lucide Svelte
  • Lucide Solid
  • Write documentation

Description

Implementation of the <Icon /> component for remaining packages which makes it easier to create (custom) icons from iconNodes.
This will be useful for future packages we want to launch like @lucide/lab and more.

Icon component

This is to create an icon with an iconNode.

Example
import { burger } from '@lucide/lab';
import { Icon } from 'lucide-react';

<Icon iconNode={burger} /> // Renders burger icon

@github-actions github-actions bot added 📦 dependencies Pull requests that update a dependency file ⚛️ react native package About the React Native package labels Mar 18, 2024
@ericfennis ericfennis added 🚀 Lucide v1 and removed 📦 dependencies Pull requests that update a dependency file ⚛️ react native package About the React Native package labels Mar 18, 2024
@github-actions github-actions bot added 📦 dependencies Pull requests that update a dependency file ⚛️ react native package About the React Native package labels Mar 18, 2024
@github-actions github-actions bot added 💎 vue package Lucide Vue package 🧣 svelte package About the Svelte package labels Mar 22, 2024
@github-actions github-actions bot added ⚛️ preact package About the Preact Package 🧳 lucide package About the lucide package 🪝 solid package About the Solid package 🅰️ angular package About the Angular package labels Apr 1, 2024
@ericfennis ericfennis marked this pull request as ready for review April 1, 2024 10:24
@ericfennis ericfennis changed the title feat(useIconComponent): Creating icons with iconNodes feat(icon-component): Creating icons with iconNodes Apr 5, 2024
@ericfennis ericfennis merged commit e50582e into lucide-icons:main Apr 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🅰️ angular package About the Angular package 📦 dependencies Pull requests that update a dependency file 📖 documentation Improvements or additions to documentation 🧳 lucide package About the lucide package 🚀 Lucide v1 ⚛️ preact package About the Preact Package ⚛️ react native package About the React Native package ⚛️ react package Lucide React Package 🌍 site Has to do something with the Lucide website 🪝 solid package About the Solid package 🧣 svelte package About the Svelte package 💎 vue package Lucide Vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant