Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license typos #2161

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix license typos #2161

merged 1 commit into from
May 24, 2024

Conversation

Sayakie
Copy link
Contributor

@Sayakie Sayakie commented May 23, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other: Fixes typos inside the README.md

Description

Fixes license typo by "ICS" to "ISC".

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added ⚛️ react package Lucide React Package 💎 vue package Lucide Vue package ⚛️ preact package About the Preact Package 🧳 lucide package About the lucide package 🧣 svelte package About the Svelte package ⚛️ react native package About the React Native package 🪝 solid package About the Solid package 🅰️ angular package About the Angular package 🪨 static package About the static package labels May 23, 2024
@karsa-mistmere karsa-mistmere merged commit 4f2a6b7 into lucide-icons:main May 24, 2024
2 checks passed
@karsa-mistmere
Copy link
Member

Good catch and nice work, thank you @Sayakie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jguddas jguddas jguddas approved these changes

Assignees
No one assigned
Labels
🅰️ angular package About the Angular package 🧳 lucide package About the lucide package ⚛️ preact package About the Preact Package ⚛️ react native package About the React Native package ⚛️ react package Lucide React Package 🪝 solid package About the Solid package 🪨 static package About the static package 🧣 svelte package About the Svelte package 💎 vue package Lucide Vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sayakie @karsa-mistmere @jguddas