New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pin icon #438
feat: pin icon #438
Conversation
mittalyashu
commented
Nov 13, 2021
•
edited
edited
- Name of the icon : Pin
- - Tags (alternative names for this icon)
Full scale | 100% |
---|---|
<img | |
@mittalyashu Nice icon!! I like it. |
@mittalyashu I like the second unpin icon in your screenshot (the one on the right). It seems to match the other "un-" / "-off" styles of the other Lucide icons, with the strikethrough connecting to the bottom-left of the icon, and the gap to the upper-right of the strikethrough. |
Co-authored-by: Eric Fennis <eric.fennis@gmail.com>
fixed! Thanks for pointing it out. |
@mittalyashu this one feels better! |
LOL! I literally forget to |
icons/pin.svg
Outdated
stroke-linecap="round" | ||
stroke-linejoin="round" | ||
> | ||
<path d="M9 3v5l-2 4v2h10M9 3h6M9 3H7m10 11h-5v7m5-7v-2l-2-4V3m0 0h2" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split this path up in smaller parts. Otherwise design programs like figma don't like it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this? Please check the most recent commit.
@mittalyashu Can you take a look, looks like you have some conflicts |
Would be great to have a tilted version as well. |
Co-authored-by: Eric Fennis <eric.fennis@gmail.com>
@locness3 What do you mean by titled version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
@mittalyashu I assume @locness3 thinks about this kind of icon. |