add option for specifying pattern as prefix

lucidphp · Feb 21, 2016 · 72d826d · 72d826d
1 parent 02ae1fb
commit 72d826d
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/src/Loader/PhpLoader.php b/src/Loader/PhpLoader.php
@@ -84,8 +84,11 @@ private function addRoutes(array $routes)
         foreach ($routes as $name => $route) {
             if ((bool)$gkeys = $this->getGroupKeys($route)) {
                 $req = isset($route['requirements']) ? $route['requirements'] : [];
+                if (null === $prefix = isset($route['pattern']) ? $route['pattern'] : $name) {
+                    continue;
+                }
                 foreach ($gkeys as $i) {
-                    $this->loadGroup($name, $req, $route[$i]);
+                    $this->loadGroup($prefix, $req, $route[$i]);
                 }
                 continue;
             }

diff --git a/tests/Loader/Fixures/route_groups.2.php b/tests/Loader/Fixures/route_groups.2.php
@@ -0,0 +1,21 @@
+<?php
+
+use Lucid\Mux\RouteCollectionBuilder;
+
+return [
+    'index' => [
+        'pattern' => '/',
+        'method' => 'GET',
+        'handler' => 'indexAction'
+    ],
+    'backstage' => [
+        'pattern' => '/admin/area',
+        [
+            'users' => [
+                'pattern' => '/user/{id}',
+                'method' => 'GET',
+                'handler' => 'userAction'
+            ]
+        ]
+    ]
+];
diff --git a/tests/Loader/PhpLoaderTest.php b/tests/Loader/PhpLoaderTest.php
@@ -53,6 +53,12 @@ public function itShouldLoadGroups()
 
         $this->assertNull($routes->get('users')->getHost());
         $this->assertSame(['http', 'https'], $routes->get('users')->getSchemes());
+
+        $loader = new PhpLoader($this->mockLocator());
+        $routes = $loader->loadRoutes('route_groups.2.php');
+
+        $this->assertNull($routes->get('users')->getHost());
+        $this->assertSame(['http', 'https'], $routes->get('users')->getSchemes());
     }
 
     /** @test */