You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for your outstanding work! I really appreciate all the effort put in this project.
I have been working with the inpaint.py implementation, which has been recently added to this repository, and I have found a couple of issues with the current implementation:
I think @nilsleh has already realized some of these issues and he has kindly fixed some of them. I am creating a new PR to address some of the remaining imperfections.
Again, thank you for your work!
The text was updated successfully, but these errors were encountered:
Dear @lucidrains,
Thank you for your outstanding work! I really appreciate all the effort put in this project.
I have been working with the
inpaint.py
implementation, which has been recently added to this repository, and I have found a couple of issues with the current implementation:p_sample
in the resample loop the input argument names are not used, and then the input parameters are incorrectly placed, causing the variablegt
be fed intox_self_cond
andmask
intogt
.p_sample_loop
with the algorithm 1 of the original paper (https://arxiv.org/pdf/2201.09865), it's clear than the resample loop should be inside the normal sampling loop and not after it at the same level.I think @nilsleh has already realized some of these issues and he has kindly fixed some of them. I am creating a new PR to address some of the remaining imperfections.
Again, thank you for your work!
The text was updated successfully, but these errors were encountered: