Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix p_sample input args and resample loop of Repaint method #320

Merged

Conversation

AlejandroSantorum
Copy link
Contributor

Closes #319 👍

Contributions:

  • Fixing input parameters of the p_sample method when called from the resample loop in the p_sample_loop method.
  • Fixing resample loop, which should be inside the usual sample loop, as described in line 9 of Algorithm 1 of the original paper https://arxiv.org/pdf/2201.09865.
  • Adding resample_every input argument to speed up sampling and resampling.
  • Improving code style by specifying input argument names in p_sample, p_sample_loop and sample.

Many thanks.

@lucidrains lucidrains merged commit b2bf73b into lucidrains:main May 22, 2024
@AlejandroSantorum AlejandroSantorum deleted the bugfix/repaint_args_and_algorithm branch May 23, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in RePaint implementation: p_sample input args and resample loop
2 participants