Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding training scripts #2

Open
isamu-isozaki opened this issue Jan 31, 2023 · 23 comments
Open

Adding training scripts #2

isamu-isozaki opened this issue Jan 31, 2023 · 23 comments

Comments

@isamu-isozaki
Copy link
Contributor

Hi! Thanks for the code! My friend and I are making a training script using this dataset

@isamu-isozaki
Copy link
Contributor Author

Will make a pr if you want!

@lucidrains
Copy link
Owner

sure, thank you!

@lucidrains
Copy link
Owner

@isamu-isozaki highly recommend the huggingface accelerate library

@isamu-isozaki
Copy link
Contributor Author

@lucidrains Sounds good! Quite a fan of it already. We are mostly done with the script but will integrate accelerate and open a pr

@lucidrains
Copy link
Owner

🙏 🚀

@Time9Y
Copy link

Time9Y commented Feb 12, 2023

Hi! Thanks for the code! My friend and I are making a training script using this dataset

Thank you very much for your contribution and look forward to your code!

@Time9Y
Copy link

Time9Y commented Feb 12, 2023

Thanks for the code, I tried to add the training code but the result was not satisfactory.

@isamu-isozaki
Copy link
Contributor Author

@Time9Y yup my friend and I are having trouble getting good results too. It kinda works on 64x64 resolution but on 128 it just breaks.
I'll try checking the paper for their params

@lucidrains
Copy link
Owner

oh this is disappointing

could i have made an error?

they released a public official repository btw

@isamu-isozaki
Copy link
Contributor Author

@lucidrains Haha no most likely we screwed up a bit. And sounds good! Will check that out. I'll add our script as a pr in a bit. Just cleaning up since it's a bit messy but maybe we can get your opinion too!

@Time9Y
Copy link

Time9Y commented Feb 14, 2023

@lucidrains This should be my problem, the code you provided is clean and efficient.

@Time9Y
Copy link

Time9Y commented Feb 14, 2023

@isamu-isozaki I've seen the code you submitted and it's so cool. Hope I can use it soon!

@isamu-isozaki
Copy link
Contributor Author

@Time9Y Thank you! Will let you know when finished

@Time9Y
Copy link

Time9Y commented Feb 15, 2023

@isamu-isozaki I've received the code, it's awesome! During training process, how many iterations did you get good results after.

@isamu-isozaki
Copy link
Contributor Author

@Time9Y Thanks! For 64x64 around 10 epochs gave me not-too-terrible results. Self-condition is pretty interesting too. Honestly, looking forward to hearing from you if u get good results!

lucidrains pushed a commit that referenced this issue Feb 15, 2023
@Time9Y
Copy link

Time9Y commented Feb 16, 2023

@isamu-isozaki Amazing, I achieved great results in 50 iterations, thanks for your contribution! This code will help our research progress.

@isamu-isozaki
Copy link
Contributor Author

@Time9Y Oh awesome! Glad it helped. What parameters did you guys use out of curiosity?

@Time9Y
Copy link

Time9Y commented Feb 16, 2023

@isamu-isozaki The parameters are basically similar to yours, while referring to this code. https://github.com/WuJunde/MedSegDiff
lr 1e-4 eopch 150 batch_size 4 UNet (1, 2, 3, 4) not use ddim

@isamu-isozaki
Copy link
Contributor Author

@Time9Y Thanks! My friend will appreciate that a lot

@lucidrains
Copy link
Owner

@isamu-isozaki Amazing, I achieved great results in 50 iterations, thanks for your contribution! This code will help our research progress.

great to hear! 🙏

@isamu-isozaki thank you so much for taking the time to contribute the training script!

@isamu-isozaki
Copy link
Contributor Author

@lucidrains Np! I wanted to contribute later to your muse repo so this was a bit of a practice run. And also, @dsbuddy helped a lot.

@isamu-isozaki
Copy link
Contributor Author

@lucidrains Sry, found a slight bug in training but made pr to fix it!

@lucidrains
Copy link
Owner

@dsbuddy thank you Daniel 💯 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants