Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Positional encoding frequency bands should be linearly spaced #52

Closed
djl11 opened this issue Sep 29, 2021 · 2 comments
Closed

Positional encoding frequency bands should be linearly spaced #52

djl11 opened this issue Sep 29, 2021 · 2 comments

Comments

@djl11
Copy link

djl11 commented Sep 29, 2021

A small bug, but as alluded to in this comment by @marcdumon, it seems as though the frequency bands are indeed spaced linearly in the official JAX implementation.
@lucidrains
Copy link
Owner

lucidrains commented Oct 4, 2021 •
edited

@djl11 thanks Daniel, i think you are correct 🙏 let me know if this version looks good to you https://github.com/lucidrains/perceiver-pytorch/releases/tag/0.7.4

jacobbieker added a commit to openclimatefix/perceiver-pytorch that referenced this issue Oct 5, 2021
@jacobbieker
Change fourier to linear space
89fd992 
Matches the paper closer, based off lucidrains#52
@jacobbieker jacobbieker mentioned this issue Oct 5, 2021
Merged
7 tasks
jacobbieker added a commit to openclimatefix/perceiver-pytorch that referenced this issue Oct 5, 2021
@jacobbieker
Change fourier to linear space
d68f87f 
Matches the paper closer, based off lucidrains#52
jacobbieker added a commit to openclimatefix/perceiver-pytorch that referenced this issue Oct 5, 2021
@jacobbieker
Change fourier to linear space
8c3672d 
Matches the paper closer, based off lucidrains#52
@djl11
Copy link
Author

djl11 commented Oct 11, 2021

Looks good!

@djl11 djl11 closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucidrains @djl11