Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sampling #17

Closed
paulnorman1 opened this issue Jan 29, 2020 · 6 comments
Closed

Implement sampling #17

paulnorman1 opened this issue Jan 29, 2020 · 6 comments

Comments

@paulnorman1
Copy link

Hello! Thank you for this repo!

Can you please implement sampling in the example file, so we'd be able to generate outputs from the model (as done in GPT-2)?

@lucidrains
Copy link
Owner

@paulnorman1 hello, the code in the example folder does just that! (but i haven't added the sampling) also to be done is proper caching during evaluation to make things fast

@paulnorman1
Copy link
Author

Excuse me, I'm not proficient in ML (I mainly test public code on my datasets). I don't see any code for generating output from the model in train.py. Is it something that you're planning on implementing?

@lucidrains
Copy link
Owner

yup, i will implement it at some point, most possibly with nucleus sampling

@paulnorman1
Copy link
Author

Great, thanks!

@lucidrains
Copy link
Owner

@paulnorman1 I've updated the example to generate text!

@paulnorman1
Copy link
Author

Awesome, thank you so much! Can't wait to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants