This repository has been archived by the owner on Sep 30, 2019. It is now read-only.
Event bus #31
Merged
Event bus #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event-bus/events everywhere
| it('should match localhost hostname with single-digit ids', () => { | ||
| ret = getDeploymentKey('fdlkasjs-4-1.localhost') as DeploymentKey; | ||
| const ret = getDeploymentKey('fdlkasjs-4-1.localhost'); | ||
| if (ret === null) { throw new Error(); } |
There was a problem hiding this comment.
Would not expect(ret).to.exist be cleaner?
There was a problem hiding this comment.
Yes, but this way TypeScript knows to narrow down DeploymentKey | null without explicit casting. The error message could be a bit more descriptive, though :D .
|
Except the two comments looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design of the
Event<T>interface is based on the discussion in here: reduxjs/redux#992.